pico_binary_info: avoid uint in standalone header#3041
Closed
Old-Ding wants to merge 1 commit into
Closed
Conversation
|
Please do not submit against |
Old-Ding
force-pushed
the
fix/binary-info-tag-uint
branch
from
fd2ffef to
d157f08
Compare
|
Please do not submit against |
Old-Ding
force-pushed
the
fix/binary-info-tag-uint
branch
from
d157f08 to
b479c2f
Compare
Contributor
|
This seems to be a duplicate of #3029 ? |
Author
|
You're right, this duplicates #3029. I'll close this PR to avoid splitting the same change across two PRs. Thanks for pointing it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3028.
pico/binary_info/structure.hdocuments that it may be included by non-SDK code and therefore should not depend on SDK includes.BINARY_INFO_MAKE_TAG()currently casts throughuint, which is not a standard C type and is only available when another header has already provided that typedef.Changes
uintcasts inBINARY_INFO_MAKE_TAG()with standardunsigned intcasts.Testing
git diff --check origin/master..HEADrg -n "BINARY_INFO_MAKE_TAG|\\buint\\b" src/common/pico_binary_info/include/pico/binary_info/structure.hgit diff --stat origin/master..HEADBuild not run locally: this Windows environment does not currently have a C compiler, CMake, Ninja, or Make available in PATH.